Re: [PATCH] gnu: Add macchanger.

[Leo Famulari]

On Thu, Apr 07, 2016 at 01:01:30PM +0200, John Darrington wrote:
> * gnu/packages/networking.scm (macchanger): New variable.

Looks good, except for some extra whitespace and a missing copyright
line for you :)

> ---
>  gnu/packages/networking.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index a4f431a..20f7e73 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -32,6 +32,28 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages compression))
>  
> +
  ^ Extraneous newline

> +(define-public macchanger
> +  (package
> +    (name "macchanger")
> +    (version "1.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnu/"
> +                                  name "/" name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1xsiivjjyhqcs6dyjcshrnxlgypvyfzacjz7gcjgl88xiw9lylri"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.gnu.org/software/macchanger";)
> +    (synopsis "Display or change the MAC address of networking devices")
> +    (description "GNU MAC Changer is a utility for viewing and changing MAC
> +addresses of networking devices.  New addresses may be set explicitly or
> +randomly.  They can include MAC addresses of the same or other hardware 
> vendors
> +or, more generally, MAC addresses of the same category of hardware.") 
                                                                        ^
                                                                        
extraneous
                                                                        
whitespace
> +    (license license:gpl2+)))
> +
> +
  ^ Extraneous newline

>  (define-public miredo
>    (package
>      (name "miredo")
> -- 
> 2.1.4
> 
>