Re: [PATCH 3/4] gnu: glib: Disable tests in build phases instead of patches.

[Efraim Flashner]

On Mon, Apr 04, 2016 at 01:26:55PM +0800, 宋文武 wrote:
> Efraim Flashner <address@hidden> writes:
> 
> > [...]
> >
> > I just applied the first three patches and glib failed to build, with
> > the following errors from the test phase:
> >
> > ERROR: gapplication - too few tests run (expected 12, got 4)
> > ERROR: gapplication - exited with status 139 (terminated by signal 11?)
> >
> > Unfortunately I didn't tell it to keep the output of the build so I
> > can't attach the test-suite.log file. It would be best if glib built
> > with this commit, just in case.
> 
> So these tests are really unreliable...  
> I did get it build sucessful with the patch on my x86-64 machine,
> and this patch doesn't enable the '/gapplication/quit' test (it pass
> too on my machine).

I think the gapplication tests error here means that it was told there
would be 12 tests to run, but it only got responses from 4 tests.

> 
> Could you build it with '-K', show the log (not very useful, IMO), and
> the run the test manually in a container environment by:
> --8<---------------cut here---------------start------------->8---
> $ guix environment -C --pure glib
> # cd gio/tests
> # ./gapplication
> --8<---------------cut here---------------end--------------->8---

/tmp/guix-build-glib-2.46.1.drv-0/glib-2.46.1/gio/tests [env]#
./gapplication
/gapplication/no-dbus: OK
/gapplication/no-appid: OK
/gapplication/properties: org.freedesktop.DBus.Error.AccessDenied:
Failed to set fd limit to 65536: Operation not permitted
OK
/gapplication/app-id: OK
/gapplication/local-actions: Segmentation fault

followed by:
/tmp/guix-build-glib-2.46.1.drv-0/glib-2.46.1/gio/tests [env]#
./gapplication -s '/gapplication/local-actions'
/gapplication/no-dbus: OK
/gapplication/no-appid: OK
/gapplication/properties: org.freedesktop.DBus.Error.AccessDenied:
Failed to set fd limit to 65536: Operation not permitted
OK
/gapplication/app-id: OK
/gapplication/local-command-line: OK
/gapplication/resource-path: OK
/gapplication/test-help: OK
/gapplication/test-busy: org.freedesktop.DBus.Error.AccessDenied: Failed
to set fd limit to 65536: Operation not permitted
OK
/gapplication/test-handle-local-options1: OK
/gapplication/test-handle-local-options2: OK
/gapplication/test-handle-local-options3: OK

so /gapplication/local-actions completely failed for me, so with my
understanding of the error that I got above (only 4/12 tests run) the
best course would be to patch/substitute the the
/gapplication/local-actions test to either pass for real or to just
return true. Or to tell it that there are only 4 (or 11) tests

> 
> Also, one can skip some test cases using something like:
> --8<---------------cut here---------------start------------->8---
> ./gapplication -s '/gapplication/quit' -s '/gapplication-remote-actions'
> --8<---------------cut here---------------end--------------->8---
> I use this to filter out mis-disabled test cases in the origin patches.
> 
> Thanks!

Actually, I attached test-suite.log and gapplication.log but deleted the
build environment before sending, and when I rebuilt it it built cleanly
for me. I'm now rebuilding it with the --check flag (and -K). And it
built again successfully.

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature