[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: r-devtools: Update to 1.10.0.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] gnu: r-devtools: Update to 1.10.0. |
Date: |
Tue, 29 Mar 2016 14:14:24 +0200 |
Hi Roel,
> Primarily because I want to use the "install_github" function in
> r-devtools, I want to update this package.
Sounds good to me.
> In this newer version, a new dependency was introduced (r-withr), which
> I also added a package recipe for.
Could you please split this into two separate patches? One adding
r-withr, the other updating r-devtools and adding r-withr.
> From 30c0938b1d1239fc1a1c894d6706c4f322395a9e Mon Sep 17 00:00:00 2001
> From: Roel Janssen <address@hidden>
> Date: Tue, 29 Mar 2016 14:00:57 +0200
> Subject: [PATCH] gnu: r-devtools: Update to 1.10.0.
> * gnu/packages/statistics.scm (r-devtools): Update to 1.10.0.
> * gnu/packages/statistics.scm (r-withr): New variable.
In addition to splitting these changes, please also mention that you
added r-withr to the propagated-inputs of r-devtools.
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 15c6823..aea3faa 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -1234,13 +1234,13 @@ informative error messages when it's not available.")
> (define-public r-devtools
> (package
> (name "r-devtools")
> - (version "1.9.1")
> + (version "1.10.0")
> (source (origin
> (method url-fetch)
> (uri (cran-uri "devtools" version))
> (sha256
> (base32
> - "10ycx3kkiz5x8nmgw31d9wa5hhlx2fhda2nqzxfrczqpz1jik6ci"))))
> + "11x51bqhjwypbxv5sfnrnxx06b92k8kzmmx7zrwk3537r072b6pa"))))
> (build-system r-build-system)
> (propagated-inputs
> `(("r-curl" ,r-curl)
> @@ -1253,13 +1253,34 @@ informative error messages when it's not available.")
> ("r-roxygen2" ,r-roxygen2)
> ("r-rstudioapi" ,r-rstudioapi)
> ("r-rversions" ,r-rversions)
> - ("r-whisker" ,r-whisker)))
> + ("r-whisker" ,r-whisker)
> + ("r-withr" ,r-withr)))
> (home-page "https://github.com/hadley/devtools")
> (synopsis "Tools to make developing R packages easier")
> (description "The devtools package is a collection of package development
> tools to simplify the devolpment of R packages.")
> (license license:gpl2+)))
OK!
> +(define-public r-withr
> + (package
> + (name "r-withr")
> + (version "1.0.1")
> + (source (origin
> + (method url-fetch)
> + (uri (cran-uri "withr" version))
> + (sha256
> + (base32
> + "0zbj3rd7dc0ycknmay7y7rm1qvnh9n05jw93gjggz46j2zfmy93y"))))
> + (build-system r-build-system)
> + (home-page "https://github.com/jimhester/withr")
> + (synopsis "Run code with temporarily modified global state")
> + (description
> + "A set of functions to run code 'with' safely and temporarily modified
> +global state. Many of these functions were originally a part of the
> 'devtools'
> +package, this provides a simple package with limited dependencies to provide
> +access to these functions.")
> + (license license:gpl2+)))
Please try to turn the first sentence fragment into an actual sentence,
even if it is just “This package provides [a] set of functions...”.
Aside from that I don’t understand the first sentence. Is “with” a
function or a keyword? If so, it should be wrapped in address@hidden But
even then I have difficulties parsing the sentence.
The second sentence seems to be a combination of two sentences glued
together by a comma. This should probably be a semicolon.
So how about this instead?
“This package provides a set of functions to run R code in an
environment in which global state has been temporarily modified.
Many of these functions were originally a part of the 'devtools'
package.”
Thanks!
~~ Ricardo