Re: [PATCH] Add the clFFT (OpenCL accelerated FFT library) package to GNU Guix

[Ricardo Wurmus]

Dennis Mungai <address@hidden> writes:

> This patch adds the clFFT library to GNU Guix.

Thanks!

My comments about your patches for clBLAS largely also apply to this
patch.  Additional comments follow.


> From 6ebec56462308cb83290d4fa4b47be07a5480674 Mon Sep 17 00:00:00 2001
> From: Dennis Mungai <address@hidden>
> Date: Sun, 20 Mar 2016 04:50:31 +0300
> Subject: [PATCH] Ported the clFFT package to GNU Guix

> ---
>  clFFT.scm | 158 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 158 insertions(+)
>  create mode 100644 clFFT.scm

For commit summaries and messages we use a variant of the ChangeLog
format.  Assuming only the addition of a “clfft” package to “maths.scm”
the commit message would look like this:

    gnu: Add clFFT.

    * gnu/packages/maths.scm (clfft): New variable.

> +(define-public clFFT
> +  (package
> +    (name "clFFT")
> +    (version "v2.10.1")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append 
> "https://github.com/clMathLibraries/clFFT/archive/";
> +                                 version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "19hrk1lf06kch8x9dpbdj0waycn2mldrmj2y4vzi7zn2gdfw6g73"))))
> +    (build-system cmake-build-system)    
> +    (arguments `(#:configure-flags '("../clFFT-2.10.1/src" 
> "-DBUILD_SHARED_LIBS=ON" "-DCMAKE_BUILD_TYPE=Release") #:tests? #f))
> +    (native-inputs `(("autoconf" ,autoconf)
> +        ("automake" ,automake)
> +        ("cmake" ,cmake)
> +        ("libtool" ,libtool)
> +        ("pkg-config" ,pkg-config)))
> +    (inputs `(("curl" ,curl)
> +       ("dbus" ,dbus)
> +       ("enca" ,enca)
> +       ("eudev" ,eudev)
> +       ("fftw-openmpi" ,fftw-openmpi)
> +       ("glew" ,glew)
> +       ("libcap" ,libcap)
> +       ("libjpeg" ,libjpeg)
> +       ("libltdl" ,libltdl)
> +       ("libtiff" ,libtiff)
> +       ("mesa-utils" ,mesa-utils)
> +       ("openmpi" ,openmpi)
> +       ("ocl-icd" ,ocl-icd)
> +       ("opencl-headers" ,opencl-headers)
> +       ("randrproto" ,randrproto)
> +       ("libxrandr" ,libxrandr)
> +       ("xineramaproto" ,xineramaproto)
> +       ("libxinerama" ,libxinerama)
> +       ("libxcursor" ,libxcursor)
> +       ("python" ,python-2)))       
> +    (home-page "http://www.glfw.org/";)
> +    (synopsis "glfw is an Open Source, multi-platform library for creating 
> windows with OpenGL contexts and receiving input and events.")
> +    (description "glfw is an Open Source, multi-platform library for 
> creating windows with OpenGL contexts and receiving input and events.")

This whole package expression looks a lot like the one for clBLAS.  Even
the synopsis and the description are the same.  Surely, that’s a
mistake.

> +(define-public ocl-icd
> +(define-public opencl-headers

Haven’t you added these two with your previous patch already?

~~ Ricardo