[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add bash-tap.
From: |
Andreas Enge |
Subject: |
Re: [PATCH] gnu: Add bash-tap. |
Date: |
Fri, 18 Mar 2016 19:53:39 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote:
> Can someone with more experience take a look and apply the patch if it's
> okay?
I had a look (without having much experience with the trivial build system),
and it looks mostly clean. However, the package installs three bash scripts
that start with "#!/bin/bash". This will not work on GuixSD, where only
/bin/sh exists. It should be patched by adding bash as an input and
substituting. Alternatively, you could use the gnu-build-system, delete most
of the phases, set #:tests? to #f and add a custom install phase; then the
patch-shebangs phase will do its magic.
Andreas