Re: [PATCH] Add ustr.

[Leo Famulari]

On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
> * gnu/packages/textutils.scm (ustr): New variable.

[...]

> +              (uri (string-append "http://www.and.org/ustr/"; version
> +                                  "/ustr-" version ".tar.bz2"))


Wow, that is a nice domain name!

It looks like this directory only contains the current version of the
code, but I can't find an archive of old releases. How about mentioning
this in a comment, and (maybe) asking and.org to provide an archive?

> +              (sha256
> +               (base32
> +                "1i623ygdj7rkizj7985q9d6vj5amwg686aqb5j3ixpkqkyp6xbrx"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc"
> +             "HIDE="

I read the Makefile's comment about this. ;)

> +             "LDCONFIG=echo"

Can you explain this one in a comment?

> +             (string-append "prefix=" (assoc-ref %outputs "out"))
> +             "all-shared")

[...]

> +    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
> +    ;; LGPL, etc. ... if you need another license to help compatibility, just
> +    ;; ask for it.  It's basically public domain, without all the legal
> +    ;; problems for everyone that trying to make something public domain
> +    ;; entails."
> +    (license license:public-domain)))

Sounds good to me. Hopefully there are no objections from the legal
experts!