[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] svn-download: Respect current-http-proxy when downloadin
From: |
Jookia |
Subject: |
Re: [PATCH 1/2] svn-download: Respect current-http-proxy when downloading. |
Date: |
Thu, 3 Mar 2016 15:32:05 +1100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Feb 28, 2016 at 05:44:18PM +0100, Ludovic Courtès wrote:
> > + (define proxy-config
> > + (if (current-http-proxy)
> > + (and-let* ((proxy-uri (string->uri (current-http-proxy)))
> > + (proxy-host (uri-host proxy-uri))
> > + (proxy-port (number->string (uri-port proxy-uri)))
> > + (config-host "servers:global:http-proxy-host=")
> > + (config-port "servers:global:http-proxy-port="))
> > + `("--config-option" ,(string-append config-host proxy-host)
> > + "--config-option" ,(string-append config-port proxy-port)))
> > + '()))
>
> I would suggest using an explicit (getenv "http_proxy") instead of
> (current-http-proxy) since the latter is specific to the (web …)
> modules, which are not involved here.
Sorry for the reply, now that I have an RFC for the coreboot patches I've looked
back at this. The URI module is also in the web module, and I'm not sure how I
feel about rewriting a URI parser to get the host and port out of http_proxy.
> Thanks!
>
> Ludo’.
Thoughts?
Jookia.
- Re: [PATCH 1/2] svn-download: Respect current-http-proxy when downloading.,
Jookia <=