[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: Add python-mpd2
From: |
Leo Famulari |
Subject: |
Re: [PATCH 1/2] gnu: Add python-mpd2 |
Date: |
Thu, 18 Feb 2016 17:00:47 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Feb 18, 2016 at 09:26:53PM +0000, Christopher Baines wrote:
> * gnu/packages/python.scm (python-mpd2): New variable
> * gnu/packages/python.scm Import lgpl3.
I actually have a patch for this in a WIP tree (attached). Based on the
differences, and the fact that I have already made the changes requested
below, I think my version of the patch should be used. My patch also
adds a python-2 version; when possible, it's preferred to add both
versions.
What do you think?
[...]
> +(define-public python-mpd2
> + (package
> + (name "python-mpd2")
> + (version "0.5.5")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "python-mpd2" version))
> + (sha256
> + (base32
> + "0laypd7h1j14b4vrmiayqlzdsh2j5hc3zv4l0fqvbrbw9y6763ii"))))
I'm glad to see we concur on this.
> + (build-system python-build-system)
> + (arguments
> + `(#:phases
> + (alist-replace
> + 'check
> + (lambda _ (zero? (system* "python" "mpd_test.py")))
> + %standard-phases)))
> + (inputs
> + `(("python-setuptools" ,python-setuptools)
> + ("python-mock" ,python-mock)
> + ("python-unittest2" ,python-unittest2)))
I don't believe that unittest2 is needed. I can build both
python-variants without it.
Setuptools is only needed for the python2-variant.
And, I think mock is only needed at build-time, so it would be a
native-input.
> + (home-page
> + "https://github.com/Mic92/python-mpd2")
> + (synopsis "Python MPD client library")
> + (description "A Python MPD client library")
Generally descriptions should be more descriptive than the synopsis.
> + (license lgpl3)))
I believe the license is lgpl3+, based on the "or later version" in
mpd.py.
> +
> +
> (define-public python-setuptools
> (package
> (name "python-setuptools")
> --
> 2.7.0
>
>
0001-gnu-Add-python-mpd2.patch
Description: Text Data