Re: [PATCH] gnu: Add libcanberra-gtk2.

[Efraim Flashner]

On Sat,  6 Feb 2016 19:48:44 +0100
Fabian Harfert <address@hidden> wrote:

> * gnu/packages/libcanberra.scm (libcanberra/gtk+-2): New variable.
> ---
>  gnu/packages/libcanberra.scm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/gnu/packages/libcanberra.scm b/gnu/packages/libcanberra.scm
> index 3769e3f..2cd75ce 100644
> --- a/gnu/packages/libcanberra.scm
> +++ b/gnu/packages/libcanberra.scm
> @@ -1,6 +1,7 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2013 Andreas Enge <address@hidden>
>  ;;; Copyright © 2014, 2015 Ludovic Courtès <address@hidden>
> +;;; Copyright © 2016 Fabian Harfert <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -96,6 +97,19 @@ GNOME.  It comes with several backends (ALSA, PulseAudio, 
> OSS, GStreamer,
>  null) and is designed to be portable.")
>      (license lgpl2.1+)))
>  
> +(define-public libcanberra/gtk+-2
> +  (package (inherit libcanberra)
> +    (name "libcanberra-gtk2")
> +    (inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("gstreamer" ,gstreamer)
> +       ("gtk+" ,gtk+-2)
> +       ("libltdl" ,libltdl)
> +       ("libvorbis" ,libvorbis)
> +       ("pulseaudio" ,pulseaudio)
> +       ("udev" ,eudev)
> +       ("sound-theme-freedesktop" ,sound-theme-freedesktop)))))
> +
>  (define-public sound-theme-freedesktop
>    (package
>      (name "sound-theme-freedesktop")

gtk is the only different input between the two variants, how about just
removing gtk from the list of inherited inputs and adding in gtk+-2? grepping
for "package-inputs" should have some examples.

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

pgpJcSvseoA_l.pgp
Description: OpenPGP digital signature