Re: [PATCH 03/04] gnu: Add python2-xdo

[Leo Famulari]

On Fri, Feb 05, 2016 at 07:48:59PM -0800, Christopher Allan Webber wrote:
> * gnu/packages/python.scm (python2-xdo): New variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    
> "http://http.debian.net/debian/pool/main/p/python-xdo/python-xdo_";

If this line is longer than 80 characters, please split the string onto
the next line.

> +                    version ".orig.tar.gz"))
> +              (sha256
> +               (base32
> +                "1kl5c1p0dyxf62plnk6fl77ycfb4whwjms16r14dxx8kn90hlqz4"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2
> +       #:tests? #f))  ; no tests provided
> +    (inputs
> +     `(("xdotool" ,xdotool)
> +       ("libX11" ,libx11)))
> +    (home-page "https://tracker.debian.org/pkg/python-xdo";)

Is it developed within Debian? Interesting if so!

> +    (synopsis "Python library for simulating X11 keyboard/mouse input 
> (libxdo bindings)")

Line length? The linter should complain if the synopsis is too long.

> +    ;; Note about this being a legacy

Did you mean to leave this comment in? ;)

> +    (description "Provides bindings to libxdo for manipulating X11 via 
> simulated
> +input.  (Note that this is mostly a legacy library; you may wish to look at
> +python-xdo for newer bindings.)")

I see, so this is a python-2 specific legacy package?

> +    (license bsd-3)))
> +
> -- 
> 2.6.3
> 
>