guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/13] build: Generate man pages after compiling guile object


From: Ludovic Courtès
Subject: Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.
Date: Sun, 31 Jan 2016 10:17:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Mathieu Lirzin <address@hidden> skribis:

> Eric Bavier <address@hidden> writes:
>
>>> +doc/guix-%.1: guix/scripts/%.scm $(GOBJECTS)
>>> +   -$(AM_V_HELP2MAN)case '$?' in \
>>> +     *$<*) $(gen_man) --output="$@" "guix `basename "$<" .scm`";; \
>>> +     *)    : ;; \
>>> +   esac
>>
>> The `basename "$<" .scm` could be reduced to $* here.
>>
>> In my patch I was trying to avoid printing the case et al in verbose
>> mode.  This should be fine though; anyone reading the output of a
>> verbose build might not be put off my the sh.
>>
>> The rest LGTM!
>
> pushed in 36629097523b0abd89d1b931293150cb9c1f242d with slight
> modifications.

Thanks to the two of you for the smart hack!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]