Re: [PATCH 6/6] gnu: Add emacs-slime.

[Federico Beffa]

On Tue, Jan 5, 2016 at 11:17 PM, Ludovic Courtès <address@hidden> wrote:
> Federico Beffa <address@hidden> skribis:
>> +         (add-before 'install 'install-doc
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (info-dir (string-append out "/share/info"))
>> +                    (doc-dir (string-append out "/share/doc/"
>> +                                            ,name "-" ,version))
>> +                    (doc-files '("doc/slime.pdf" "doc/slime-refcard.pdf"
>> +                                 "README.md" "NEWS" "PROBLEMS"
>> +                                 "CONTRIBUTING.md")))
>> +               (with-directory-excursion "doc"
>> +                 (substitute* "Makefile"
>> +                   (("infodir=/usr/local/info")
>> +                    (string-append "infodir=" info-dir)))
>> +                 (system* "make" "all")
>> +                 (install-file "slime.info" info-dir)
>> +                 (copy-recursively "html" (string-append doc-dir "/html")))
>> +               (for-each (lambda (f)
>> +                           (install-file f doc-dir)
>> +                           (delete-file f))
>> +                         doc-files)
>> +               (delete-file-recursively "doc")
>
> Can we build and install only Info files?  This is what we usually do
> for packages that have Texinfo manuals.  Incidentally, it allows us to
> get rid of the TeX Live dependency.

I'm OK to remove slime.pdf, but the slime-refcard.pdf is quite useful.
(See mit-scheme thread for my opinion on TeXLive.)

>
>> +    (synopsis
>> +     "Superior Lisp Interaction Mode for Emacs")
>
> Move to previous line.

OK. Note that this is coming straight out of Guile's 'pretty-print'...
that's Guile's developers style, not mine :-)

> Could you send an updated patch?

Attached.

Thanks for the review,
Fede

0006-gnu-Add-emacs-slime.patch
Description: Text Data