Re: [PATCH] Rename icedtea{6,7}.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> The following patches rename the packages “icedtea6” and “icedtea7” to
> just “icedtea”, and the variables “icedtea6” and “icedtea7” to
> “icedtea-6” and “icedtea-7”.  They also add a default “icedtea”, which
> is just an alias for “icedtea-7”.  Packages needing a JDK or JRE can now
> just add “icedtea” to their inputs.

This sounds reasonable to me, but what’s the rationale?  Is it that
people have no reason to use the older version?

> As soon as IcedTea 8/3.0.0 is released I’d like to remove the
> “icedtea-6” package.  “icedtea-7” has to stay around because “icedtea-8”
> cannot be bootstrapped with GCJ any more; it needs a more recent JDK.

Bah, pity, but good that we already have everything.

> From 3f27f5c2b802bd9b86592b360ab40b26351cd6f9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 30 Dec 2015 14:04:04 +0100
> Subject: [PATCH 1/5] gnu: icedtea6, icedtea7: Unpack to "openjdk.src".
>
> * gnu/packages/java.scm (icedtea6)[arguments]: Unpack OpenJDK sources to
> "openjdk.src".
> (icedtea7)[arguments]: Inherit "--with-openjdk-src-dir" flag; refer to
> "openjdk.src" in build phases; simplify "unpack" phase.
> [native-inputs]: Rename "openjdk-drop" to "openjdk-src".

LGTM.

> From 679d16cf33ce960c74cb625ce591b35af28cf69c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 30 Dec 2015 14:25:09 +0100
> Subject: [PATCH 2/5] gnu: Add and use default IcedTea.
>
> * gnu/packages/java.scm (icedtea): New variable.
> (swt)[native-inputs]: Replace "icedtea6" with "icedtea".
> * gnu/packages/bioinformatics.scm (htsjdk)[native-inputs]: Likewise.
> (ngs-java)[inputs]: Likewise.
> * gnu/packages/kodi.scm (kodi)[native-inputs]: Replace "icedtea7" with
> "icedtea".
> * gnu/packages/ruby.scm (ruby-rjb)[native-inputs]: Replace "icedtea7"
> with "icedtea".

Sure.

> From 85edda9b737468967d517164bf332aa66ba79513 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 30 Dec 2015 14:31:16 +0100
> Subject: [PATCH 3/5] gnu: icedtea6, icedtea7: Rename package to "icedtea".
>
> * gnu/packages/java.scm (icedtea6): Change package name to "icedtea".
> (icedtea7): Inherit package name.

OK.

> From bea8acc2fcad03743437f1a604dd38b9f5c11996 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 30 Dec 2015 14:33:11 +0100
> Subject: [PATCH 4/5] gnu: icedtea6: Rename to icedtea-6.
>
> * gnu/packages/java.scm (icedtea6): Rename variable to...
> (icedtea-6): ...this.

OK.

> From a1a6394e7a4666f8b8dbb2661a69b6b5a6dcae31 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 30 Dec 2015 14:34:25 +0100
> Subject: [PATCH 5/5] gnu: icedtea7: Rename to icedtea-7.
>
> * gnu/packages/java.scm (icedtea7): Rename variable to...
> (icedtea-7): ...this.
> (icedtea): Refer to "icedtea-7".

OK!

Thanks!

Ludo’.