[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] guix pypi importer: Add ending as an optional argument to py
From: |
Cyril Roelandt |
Subject: |
Re: [PATCH] guix pypi importer: Add ending as an optional argument to pypi-uri. |
Date: |
Tue, 5 Jan 2016 01:53:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0 |
On 01/03/2016 10:36 PM, swedebugia wrote:
> ---
> guix/build-system/python.scm | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm
> index 2532210..09074ce 100644
> --- a/guix/build-system/python.scm
> +++ b/guix/build-system/python.scm
> @@ -41,13 +41,20 @@
> ;;
> ;; Code:
>
> -(define (pypi-uri name version)
> +(define* (pypi-uri name version
> + #:optional
> + ending)
Could we use "tar.gz" as the default value of ENDING as to avoid the
need for a test in this function?
Also, it would be nice to update the pypi importer as well, so that it
detects the right suffix.
I also think "ending" should be renamed to "extension" or something like
that.
WDYT?
Cyril.