guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Update Julia to 0.4.2.


From: Ludovic Courtès
Subject: Re: [PATCH] Update Julia to 0.4.2.
Date: Wed, 30 Dec 2015 16:57:47 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> this patch series updates our “julia” package to version 0.4.2.  An
> update to version 1.3.1 of “utf8proc” was required.  I also made the
> dependency on a patched version of “libuv” explicit by creating a
> separate “julia-libuv” package.

Sounds good.

> Unfortunately, the build for “julia” is not reproducible.  I haven’t yet
> investigated what might be the cause and I don’t know yet how large the
> difference between two builds is.

Julia is not mentioned in packages.yml in
<git://git.debian.org/git/reproducible/notes.git>, so I guess nobody has
looked at it yet.

When you have diff or Diffoscope info about the differences, please open
a bug.

> From 416b5a0ef40cd2dff304db55846a258210388bb3 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Mon, 30 Nov 2015 14:31:02 +0100
> Subject: [PATCH 1/3] gnu: utf8proc: Update to 1.3.1.
>
> * gnu/packages/textutils.scm (utf8proc): Update to 1.3.1.
> [arguments]: Remove custom "install" phase.

OK.

> From 034cdddd452c036d5155a56da35d20e97d0e9f28 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Mon, 30 Nov 2015 14:22:18 +0100
> Subject: [PATCH 2/3] gnu: Add libuv-julia.
>
> * gnu/packages/julia.scm (libuv-julia): New variable.

[...]

> +(define-public libuv-julia

Perhaps this can be kept private?  If not, I would suggest changing the
‘synopsis’ field as well.

Otherwise LGTM.

> From 22027c25fd92c5f9821539fcf0b63fe763104ac0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Mon, 30 Nov 2015 14:25:53 +0100
> Subject: [PATCH 3/3] gnu: julia: Update to 0.4.2.
>
> * gnu/packages/patches/julia-0.3.10-fix-empty-array.patch: Remove file.
> * gnu-system.am (dist_patch_DATA): Remove it.
> * gnu/packages/julia.scm (julia): Update to 0.4.2.
> [arguments]: Remove phase "fix-building-with-mcjit-llvm"; replace phase
> "patch-include-path" with "fix-include-and-link-paths"; add phase
> "hardcode-paths"; add missing make-flags.
> [inputs]: Replace "pcre" with "pcre2"; replace "git" with "libgit2"; add
> "coreutils"; add "libuv-julia"; add "wget"; add "which".
> [native-inputs]: Remove "which".

LGTM.

Thanks, and sorry for the delay!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]