[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: Add cuetools.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH 1/2] gnu: Add cuetools. |
|
Date: |
Tue, 29 Dec 2015 19:55:47 -0500 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Dec 30, 2015 at 12:26:19AM +0100, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
>
> > * gnu/packages/audio.scm (cuetools): New variable.
>
> [...]
>
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'bootstrap
> > + (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
>
> Note that, as per a recent rule, the “(lambda” should be aligned with
> the ‘d’ of ‘add-after’.
Done.
>
> > + (home-page "https://github.com/svend/cuetools";)
> > + (license license:gpl2)))
>
> AFAICS, source file headers do not mention a specific GPL version; thus,
> it should be ‘gpl2+’.
Done.
>
> Otherwise LGTM, thanks!
Pushed as 6da16993eb.
>
> Ludo’.