Re: noisy union-build

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> whenever I build a new profile generation I see a lot of noise like
> this:
>
> ~~~~~~~~~~~~~~~
> ...
> `/gnu/store/k3r21zq5nrrkdp303vlw1cc2mrhhcl7b-ibus-1.5.11/share/icons/hicolor/scalable/apps/ibus-setup.svg'
>  ~> 
> `/gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/hicolor/scalable/apps/ibus-setup.svg'
> `/gnu/store/d6i21sw7nq7cdabp9k6k9y3mrl67lbbp-emacs-24.5/share/icons/hicolor/scalable/apps/emacs.svg'
>  ~> 
> `/gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/hicolor/scalable/apps/emacs.svg'
> `/gnu/store/k3r21zq5nrrkdp303vlw1cc2mrhhcl7b-ibus-1.5.11/share/icons/hicolor/scalable/apps/ibus.svg'
>  ~> 
> `/gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/hicolor/scalable/apps/ibus.svg'
> `/gnu/store/i7x10knncm1b7r3202dsijsqrqvq1s6p-geda-gaf-1.8.2/share/icons/hicolor/scalable/apps/geda-gattrib.svg'
>  ~> 
> `/gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/hicolor/scalable/apps/geda-gattrib.svg'
> `/gnu/store/i7x10knncm1b7r3202dsijsqrqvq1s6p-geda-gaf-1.8.2/share/icons/hicolor/scalable/apps/geda-gschem.svg'
>  ~> 
> `/gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/hicolor/scalable/apps/geda-gschem.svg'
> ...
> ~~~~~~~~~~~~~~~
>
> This is produced by the local ‘symlink*’ procedure inside of the
> ‘union-build’ procedure in ‘guix/build/union.scm’.
>
> Could we please show all of this only upon request, e.g. when running in
> verbose mode or by producing a profile log file or something?

I’m committing this patch, which is consistent with what (guix build
profiles) does:

modified   guix/profiles.scm
@@ -658,7 +658,8 @@ creates the GTK+ 'icon-theme.cache' file for each theme."
 
             ;; Union all the icons.
             (mkdir-p (string-append #$output "/share"))
-            (union-build destdir icondirs)
+            (union-build destdir icondirs
+                         #:log-port (%make-void-port "w"))
 
             ;; Update the 'icon-theme.cache' file for each icon theme.

> To a lesser degree this also applies to repeated messages like:
>
>     gtk-update-icon-cache: Cache file created successfully.

I’m pushing this:

modified   guix/profiles.scm
@@ -669,7 +669,7 @@ creates the GTK+ 'icon-theme.cache' file for each theme."
                  ;; "abiword_48.png".  Ignore these.
                  (when (file-is-directory? dir)
                    (ensure-writable-directory dir)
-                   (system* update-icon-cache "-t" dir))))
+                   (system* update-icon-cache "-t" dir "--quiet"))))
              (scandir destdir (negate (cut member <> '("." ".."))))))))
 

> as well as these messages (because as a user I cannot do anything about them):
>
>     install-info: warning: no info dir entry in 
> `/gnu/store/q9yx6mz6zw0z4hfivqb5pba8xpf3bx0a-lilypond-2.19.27/share/info/music-glossary.info.gz'

I agree that as a user there’s nothing you can do.  But I think it’s
really a bug that we should report upstream, rather than hide it.

We need someone who’s familiar with the LilyPond crowd (hint hint ;-))
to send the one-liner that will fix it.  WDYT?

> and finally the verbose and unsighty collision warnings:
>
>     warning: collision encountered: 
> /gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/HighContrast/icon-theme.cache
>  
> /gnu/store/xjbvns4ammyxcijzg8q094xbbww6wic0-dconf-0.22.0/share/icons/HighContrast/icon-theme.cache
>  
> /gnu/store/fh6kwdjhxmvfc5xvs4zqawinaggy70r0-gnome-themes-standard-3.16.2/share/icons/HighContrast/icon-theme.cache
>  
> warning: arbitrarily choosing 
> /gnu/store/z6na5mb36gqr0m018ci2ji9y4qkgjnbr-gtk-icon-themes/share/icons/HighContrast/icon-theme.cache
>
> I wouldn’t mind the collision warnings so much if they were a little
> prettier, even at the expense of using up more vertical space.
>
> What do you think?

We should get a warning when there really is a problem.

As discussed a while back, the problem, to me, is that there are
collisions like those above that we should and could address.

We discussed the issue of icon-theme.cache and other issues in September
(see “Dealing with common collisions in profiles.”)  ISTR that Federico
concluded that we cannot remove icon-theme.cache files, despite having
now an icon-cache-generating hook in (guix profiles).

If that is the case and nobody has a better idea, I’m ready to add a
hack whereby we would give ‘union-build’ a white list of files whose
collisions should be silently ignored.

WDYT?

Ludo’.