[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add docopt.
From: |
Kyle Meyer |
Subject: |
Re: [PATCH] gnu: Add docopt. |
Date: |
Thu, 03 Dec 2015 18:17:42 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Leo Famulari <address@hidden> writes:
> On Thu, Dec 03, 2015 at 01:24:09AM -0500, Kyle Meyer wrote:
>> * gnu/packages/python.scm (python-docopt, python2-docopt): New
>> variables.
>
> Have you tested the software provided by this patch to make sure it
> works? I'm not sure how to test it since it's just a library.
Yes, I've been using the py3 version locally for a while and haven't
noticed any issues. I didn't test the py2 version.
>> + (arguments '(#:tests? #f)) ; Tests are not included in the PyPI
>> release.
>
> Are there tests in any other releases? If not, I would change the
> comment to "No test suite", just to make it more clear. If yes, we
> should probably package that release while asking upstream to include
> the tests in the PyPi release.
There's a test file in the GitHub repo. I'll open a PR adding it to the
source distribution and change the package definition to use the GitHub
source for now.
Thanks for the feedback. I'll send an update.
[I also just realized that I put docopt rather than python-docopt in the
commit subject.]
--
Kyle