guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add python-pystache.


From: Ludovic Courtès
Subject: Re: [PATCH] Add python-pystache.
Date: Wed, 18 Nov 2015 12:13:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Erik Edrosa <address@hidden> skribis:

> This is my first try at creating a package and patch for GNU Guix. I did
> my best to follow the guidelines, but if there is any problems I can
> correct them. Be sure to check if the synopsis and description are
> appropriate for the package.

The description could be expounded a bit, but it’s OK.

> From bb20406631bd3d93e7d72912b0f36dc1fd38e9ff Mon Sep 17 00:00:00 2001
> From: Erik Edrosa <address@hidden>
> Date: Sun, 15 Nov 2015 20:29:46 -0500
> Subject: [PATCH] gnu: Add python-pystache.
>
> * gnu/packages/python.scm (python-pystache, python2-pystache): New
>   variables.

[...]

> +       (uri (string-append
> +             "https://pypi.python.org/packages/source/p/pystache/pystache-";
> +             version ".tar.gz"))

I changed this to use ‘pypi-uri’…

> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)))

… and this to ‘native-inputs’ (setuptools is a build-only dependency
where we’d need the native version when cross-compiling.)

Committed, thank you, and welcome!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]