guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] gnu: Add gdm.


From: Ludovic Courtès
Subject: Re: [PATCH 4/5] gnu: Add gdm.
Date: Wed, 11 Nov 2015 22:19:16 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

宋文武 <address@hidden> skribis:

> * gnu/packages/gnome.scm (gdm): New variable.

[...]

> +     '(#:configure-flags
> +       '("--without-plymouth")

Should be on a single line.

> +       (modify-phases %standard-phases
> +         (add-before
> +          'configure 'pre-configure

Could use the indentation suggested by Alex, but no big deal.

> +            ;; Use elogind for sd-login.
> +            (substitute* '("common/gdm-common.c"
> +                           "daemon/gdm-manager.c"
> +                           "libgdm/gdm-user-switching.c")
> +              (("#include <systemd/sd-login\\.h>")
> +               "#include <elogind/sd-login.h>"))
> +            ;; Avoid checking SYSTEMD using pkg-config.

That’s cool.

The rest LGTM.

So…  Next step is to have a GDM service in GuixSD.  :-)

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]