Re: [PATCH 1/2] gnu: Add gtksourceview.

[David Hashe]

On Sun, Nov 8, 2015 at 6:03 AM, 宋文武 <address@hidden> wrote:

David Hashe <address@hidden> writes:

> * gnu/packages/gnome.scm (gtksourceview): New variable.
> ---
>  gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 5440433..9bd1c31 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3659,3 +3659,37 @@ environment that allows users to view, unpack, and create compressed archives
>  such as gzip tarballs.")
>      (home-page "http://fileroller.sourceforge.net/")
>      (license license:gpl2+)))
> +
> +(define-public gtksourceview
> + (package
> +   (name "gtksourceview")
> +   (version "3.16.1")
Why not use the latest stable 3.18.x?

Changed to 3.18.1.

 

> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "mirror://gnome/sources/" name "/"
> +                                (version-major+minor version) "/"
> +                                name "-" version ".tar.xz"))
> +            (sha256
> +             (base32
> +              "030v7x1dmx5blqi9jcknsjd91jppbpl7f4z69k8c8kklr939i7k6"))))
> +   (build-system glib-or-gtk-build-system)
> +   (arguments
> +    '(#:tests? #f)) ; Tries to open graphical display during testing and fails
> +   (native-inputs
> +    `(("intltool" ,intltool)
> +      ("itstool", itstool)
> +      ("gobject-introspection" ,gobject-introspection)
> +      ("pkg-config" ,pkg-config)))
> +   (inputs
> +    `(("glib" ,glib)
> +      ("gtk+" ,gtk+)
> +      ("libxml2" ,libxml2)
> +      ("pango" ,pango)
> +      ("gdk-pixbuf" ,gdk-pixbuf)
> +      ("vala" ,vala)))
> +   (home-page "https://wiki.gnome.org/Projects/GtkSourceView ")
                                              extra space      ^
> +   (synopsis "GNOME source code widget")
> +   (description "GtkSourceView is a text widget that extends the standard
> +GTK+ text widget GtkTextView. It improves GtkTextView by implementing syntax
We use two spaces after period  ^

Fixed.

 

> +highlighting and other features typical of a source code editor.")
> +   (license license:lgpl2.1+)))

Thanks for the feedback! I've attached an updated patch.

0001-gnu-Add-gtksourceview.patch
Description: Text Data