[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] system: container: Update to new service API.
|
From: |
Thompson, David |
|
Subject: |
Re: [PATCH] system: container: Update to new service API. |
|
Date: |
Thu, 29 Oct 2015 00:19:00 -0400 |
On Tue, Oct 27, 2015 at 9:22 AM, Ludovic Courtès <address@hidden> wrote:
> Sorry, I meant to preserve #:container? behavior but I forgot this bit.
>
> I believe the attached patch provides an Even Greater Way to address the
> problem, namely by making the modprobe/firmware thing an optional
> service.
>
> Could you try and report back? I tried it in a VM and there’s no
> regression.
It works great, thanks! If you make a commit from this, I will reduce
this patch to simply fixing gnu/system/linux-container.scm.
> Besides, we’ll have to make sure ‘guix system extension-graph’ honors
> --container.
Hmm, yes, good point. I haven't looked at that code at all since it is so new.
- Dave