Re: [PATCH] gnu: Add ghc-sdl-mixer.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth address@hidden:
>> +     `(#:configure-flags
>> +       (let* ((sdl-mixer (assoc-ref %build-inputs "sdl-mixer"))
>> +              (sdl-mixer-lib (string-append sdl-mixer "/lib"))
>> +              (sdl-mixer-include (string-append sdl-mixer "/include/SDL")))
>> +         (list (string-append "--extra-include-dirs=" sdl-mixer-include)
>> +               (string-append "--extra-lib-dirs=" sdl-mixer-lib)))
>
> Is the --extra-lib-dirs argument really necessary?  I think
> haskell-build-system already passes flags for every "lib" directory it
> sees in inputs.

Indeed, that was a troubleshooting remnant.  Thanks!  Removed.

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before
>> +          'configure 'fix-/bin/sh
>> +          (lambda _
>> +            ;; Use `sh', not `/bin/sh'.
>> +            (substitute* (find-files "." "Makefile|configure")
>> +              (("/bin/sh") "sh")))))))
>
> See comments about ghc-doctest package.

I assume you mean the more elegant CONFIG_SHELL environment variable
patch?  If so, it's been fixed.

>> +    (propagated-inputs
>> +     `(("sdl-mixer" ,sdl-mixer)
>
> I can understand propagating ghc-sdl, but is it necessary to propagate the
> sdl-mixer library too?

You're right, it's not.  Removed.

>> +       ("ghc-sdl" ,ghc-sdl)))
>> +    (home-page
>> +     "http://hackage.haskell.org/package/SDL-mixer";)
>> +    (synopsis "Binding to libSDL_mixer")
>
> "Haskell bindings to libSDL_mixer"

Fixed.

> Similar comments for the ghc-sdl-image patch.

The same changes have been applied to ghc-sdl-image.

Thank you!
p.