Re: [PATCH 3/3] gnu: Add cmus.

[Ludovic Courtès]

Paul van der Walt <address@hidden> skribis:

> * gnu/packages/music.scm (cmus): New variable.

[...]

> +     `(#:tests?
> +       #f                               ; cmus does not include tests

Should be on one line.

> +              ;; It's an idiosyncratic configure script that doesn't
> +              ;; understand --prefix=..; it wants prefix=.. instead.
> +              (setenv "CONFIG_SHELL" (which "bash"))

It probably doesn’t honor ‘CONFIG_SHELL’ either, in which case this line
can be removed.

> +       ("pkg-config" ,pkg-config)

Should be ‘native-inputs’.

> +     (home-page "https://cmus.github.io/";)
> +     (synopsis "Small, fast and powerful console music player")

“Small console music player”?

> +     (description "Cmus is a small, fast and powerful console music player 
> for
> +Unix-like operating systems.")

What about something like:

  Cmus is a small and fast console music player.  It supports many
  input formats and output options and provides a customizable Vi-style
  user interface.

OK with these changes!

Ludo’.