guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: Add evilwm.


From: Eric Bavier
Subject: Re: [PATCH 2/2] gnu: Add evilwm.
Date: Mon, 19 Oct 2015 06:55:41 -0500

On Fri, 16 Oct 2015 10:37:43 +0200
address@hidden (Ludovic Courtès) wrote:

> address@hidden skribis:
> 
> > From: Eric Bavier <address@hidden>
> >
> > * gnu/packages/wm.scm (evilwm): New variable.
> 
> [...]
> 
> > +                   'build 'provide-better-default-font
> > +                   (lambda _
> > +                     ;; The "fixed" font is contained in the set of fonts
> > +                     ;; installed with the default xorg-server service, so 
> > use
> > +                     ;; it as the default instead.
> > +                     (substitute* "evilwm.h"
> > +                       (("^#define DEF_FONT[[:space:]]*\"variable\"")
> > +                        "#define DEF_FONT \"fixed\""))
> 
> What about adding the “variable” font by default in (gnu services xorg)
> instead?

The attached patches:

0002) patch our font-alias package so that the xserver will honor its
alias definitions.
0003) Add font-alias directories to the default FontPath in our
xorg-server service.
0004) Amends the previous patch to remove the change to evilwm's default
font.

> 
> > +    (license (fsf-free "file:///README"))))
> 
> Since ‘fsf-free’ is a catch-all thing, could you add a comment
> explaining in one line what kind of license this is?

Upon closer reading of the README, I've updated the license field to
'(x11-style "file:///README")'.  Of course, second opinions welcome,
especially since http://directory.fsf.org/wiki/Evilwm claims both
"Other" and "GPLv2orlater" licenses, and
http://directory.fsf.org/wiki/Aewm which evilwm is based on claims the
"Expat" license.

`~Eric

Attachment: 0002-font-alias-Install-dummy-fonts.dir-files.patch
Description: Binary data

Attachment: 0003-services-xorg-Include-font-alias-in-default-FontPath.patch
Description: Binary data

Attachment: 0004-gnu-Add-evilwm.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]