[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add python-xlrd.
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH] gnu: Add python-xlrd. |
Date: |
Sat, 19 Sep 2015 22:37:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> writes:
> Mathieu Lirzin <address@hidden> writes:
>
>>> + ;; so use nose to run tests instead for now.
>>> + (replace 'check (lambda _ (zero? (system* "nosetests")))))))
>>> + (native-inputs
>>> + `(("python-setuptools" ,python2-setuptools)
>>> + ("python-nose" ,python2-nose)))
>>
>> I don't know python packaging but when I look at other packages it
>> seems that these are usually used as “inputs” not
>> “native-inputs”.
>
> Nose is used for the tests only and setuptools is used at build time, so
> I think it’s fine like this.
Is this a general statement or something specific to this package? If
this is general it seems to be a good idea to make a big commit that
fixes all the python packages which use these dependencies as normal
inputs? WDYT?
--
Mathieu Lirzin