Re: [PATCH] gnu: Add ruby-bio-logger.

[Ricardo Wurmus]

Hi Pjotr,

> * gnu/packages/ruby.scm (ruby-bio-logger): New variable.

[...]
  
> +(define-public ruby-bio-logger
> +  (package
> +    (name "ruby-bio-logger")
> +    (version "1.0.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (rubygems-uri "bio-logger" version))
> +        (sha256
> +          (base32
> +            "02pylfy8nkdqzyzplvnhn1crzmfkj1zmi3qjhrj2f2imlxvycd28"))))

This opening quote of this string should be aligned with the “b” in
“base64”.  Likewise, the opening parenthesis of “(base32 ...)” should be
aligned with the “s” in “(sha256 ...)”, and “(origin” should be aligned
with the “s” of “(source”.

Are you using Emacs to indent?  In many cases you can just use ‘M-x
indent-sexp’.

> +    (build-system ruby-build-system)
> +    (propagated-inputs `(("ruby-log4r" ,ruby-log4r)))
> +    (arguments
> +     '(#:tests? #f)) ; no test suite
> +    (synopsis "Log4r wrapper for Ruby with extra features")
> +    (description "Library with extra logging features on top of
> +ruby-log4r (not specific to bioinformatics)")

This is not a complete description as it is not a full sentence.  A
minimal description might be

  “Bio-logger is a wrapper around Log4r adding extra logging features
such as x, y, and z.”

The README at the Github site is rather detailed; mentioning a few of
the added features in the description would be nice.

> +    (home-page "https://github.com/pjotrp/bioruby-logger-plugin";)
> +    (license license:expat)))
> +
>  (define-public ruby-atoulme-antwrap
>    (package
>      (name "ruby-atoulme-antwrap")

~~ Ricardo