guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: Add Attic.


From: Alex Kost
Subject: Re: [PATCH 3/3] gnu: Add Attic.
Date: Sun, 30 Aug 2015 22:58:06 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Leo Famulari (2015-08-26 20:16 +0300) wrote:

> +(define-public attic
> +  (package
> +   (name "attic")
> +   (version "0.16")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "https://pypi.python.org/packages/source/A/Attic/Attic-";
> +                   version ".tar.gz"))
> +            (sha256
> +             (base32 
> "0b5skd36r4c0915lwpkqg5hxm49gls9pprs1b7hc40910wlcsl36"))))
> +   (build-system python-build-system)
> +   (arguments
> +    `(#:phases (modify-phases %standard-phases
> +     (add-before
> +      'build 'set-openssl-prefix
> +      (lambda* (#:key inputs #:allow-other-keys)
> +        (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl"))
> +        #t)))))

Please align modify-phases clause like this:

(modify-phases %standard-phases
  (add-before
   'build 'set-openssl-prefix
   (lambda* (#:key inputs #:allow-other-keys)
     (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl"))
     #t)))

The rest LGTM, thank you.

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]