Re: [PATCH 2/2] gnu: Add d-feet.

[Mark H Weaver]

One more thing:

宋文武 <address@hidden> writes:
> +       (modify-phases %standard-phases
> +         (add-before
> +          'check 'pre-check
> +          (lambda* (#:key inputs #:allow-other-keys)
> +            ;; The test suite requires a running X server.
> +            (system (format #f "~a/bin/Xvfb :1 &"
> +                            (assco-ref inputs "xorg-server")))
> +            (setenv "DISPLAY" ":1")
> +            ;; Don't fail on missing '/etc/machine-id'.
> +            (setenv "DBUS_FATAL_WARNINGS" "0")
> +            ;; tests.py and window.py don't meet E402:
> +            ;;   E402 module level import not at top of file
> +            (substitute* "src/tests/Makefile"
> +              (("--ignore=E123") "--ignore=E123,E402"))))

I forgot to mention that you should add #t here, since phase procedures
are supposed to return a boolean, but the return value of 'substitute*'
is unspecified.

     Thanks,
       Mark