[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] scripts: package: Add --install-from-file option.
|
From: |
Thompson, David |
|
Subject: |
Re: [PATCH] scripts: package: Add --install-from-file option. |
|
Date: |
Wed, 19 Aug 2015 22:26:28 -0400 |
On Wed, Aug 19, 2015 at 6:38 PM, Ludovic Courtès <address@hidden> wrote:
> "Thompson, David" <address@hidden> skribis:
>
>> On Tue, Aug 18, 2015 at 3:30 PM, Ludovic Courtès <address@hidden> wrote:
>
>> From 471fff182b632fc3b6f99925ff6c7bd25850a841 Mon Sep 17 00:00:00 2001
>> From: David Thompson <address@hidden>
>> Date: Sun, 9 Aug 2015 11:35:51 -0400
>> Subject: [PATCH] scripts: package: Add --install-from-file option.
>>
>> * guix/scripts/package.scm (show-help): Add help text for --install-from-file
>> option.
>> (%options): Add --install-from-file option.
>> * doc/guix.texi ("invoking guix package"): Document it.
>> * doc/package-hello.scm: New file.
>> * doc.am (EXTRA_DIST): Add it.
>
> LGTM!
>
> In total sloppiness I forgot to ask you for a test, but you’re welcome
> to post it separately. :-)
>
> I think a couple of lines in tests/guix-package.sh would do, where the
> given file would just evaluate to ‘%bootstrap-guile’ for instance. How
> does that sound?
Done and pushed. Thanks!
- Dave