Re: [PATCH] build: ruby: Rewrite build system to use gem archives.

[Thompson, David]

On Sun, Aug 16, 2015 at 6:19 PM, Thompson, David
<address@hidden> wrote:
> Update:
>
> On Tue, Jul 28, 2015 at 9:09 AM, David Thompson
> <address@hidden> wrote:
>
>> One other caveat is that downloading gems from rubygems.org currently
>> *does not* work because the HTTP responses include an invalid
>> Content-Type header.  I added a temporary hack to do my development
>> work (not in this patch), and I'm currently waiting on a response from
>> the rubygems.org admins to see if they will fix the issue.  So, this
>> patch should not be applied until this is resolved.
>>
>> See: 
>> http://help.rubygems.org/discussions/problems/21223-invalid-content-type-header-when-downloading-gem-archive?unresolve=true
>
> This issue has been fixed by the rubygems.org admins!  I would like to
> apply the below patch ASAP and get to work on 'guix import gem' if
> there are no objections.
>
> The major change from the previous version of this patch is that I
> figured how to unpack the source gem, allow the package build script
> to make any necessary dynamic patches, and then install a repacked gem
> as opposed to the source gem.

I found a problem with this system when it came to running certain
test suites that used Bundler to read the gemspec.  A lot of upstream
gemspec include things like shell commands to run 'git ls-files' and
things.  In the former build system, the 'gitify' phase took care of
this.  Now, we can more easily deal with it by asking the 'gem'
utility to generate a gemspec for us based on the source gem archive.
Hope that wasn't too confusing for the non-Rubyists.

TIA for review.

- Dave

0001-build-ruby-Rewrite-build-system-to-use-gem-archives.patch
Description: Text Data