Re: [PATCH] gnu: python-2: update to 2.7.10.

[Mark H Weaver]

Hi Andreas,

Andreas Enge <address@hidden> writes:
> something does not work as expected in your commit
> 9f6509c655b766b0fb9dfab181a8533e698473b0 to accomodate python version
> numbers with two-digit components. Now the files are installed into
> lib/python.7. for python-2 modules

Actually, that's precisely the problem that was fixed by
9f6509c655b766b0fb9dfab181a8533e698473b0.

> (see, for instance, python2-sip).

The reason it still fails for python2-sip is because python-sip
contains another copy of the same faulty code that I fixed in
9f6509c655b766b0fb9dfab181a8533e698473b0:

--8<---------------cut here---------------start------------->8---
                   (python-version
                     (string-take
                       (string-take-right (assoc-ref inputs "python") 5)
                       3))
--8<---------------cut here---------------end--------------->8---

The commit logs show that you wrote both of these pieces of code: the
one above, and the one I already fixed.

Please don't assume that version numbers contain only single-digit
components.  In Scheme we have the tools to conveniently do this job
properly.

I'll leave it to you to fix this instance of the bug.  If you know of
any other occurrences of the same bug, can you fix them also?

     Thanks,
       Mark