[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Update enlightenment.scm: Add Rage Player
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] Update enlightenment.scm: Add Rage Player |
Date: |
Thu, 06 Aug 2015 16:24:22 +0200 |
Thanks for the updated patch!
> * gnu/packages/enlightenment.scm: Add Rage.
This should really be:
* gnu/packages/enlightenment.scm (rage): New variable.
Other than that I have no important objections. I think this looks ugly
and could be improved, but I don’t think it’s very important:
> + (uri
> + (string-append
> + "http://download.enlightenment.org/rel/apps/rage/rage-"
> + version ".tar.gz"))
I’d put “(uri (string-append ...” on the same line, pull part of the
string onto the same line and align the rest accordingly.
But I better leave the comments and the final decision to someone else.
~~ Ricardo