Re: [PATCH 3/3] gnu: colord: Propagate inputs.

[宋文武]

Mark H Weaver <address@hidden> writes:

> 宋文武 <address@hidden> writes:
>
>> * gnu/packages/gnome.scm (colord): Propagate inputs glib, eudev and lcms.
>> ---
>>  gnu/packages/gnome.scm | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 11afb61..738047e 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -2181,11 +2181,14 @@ keyboard shortcuts.")
>>         ("gobject-introspection" ,gobject-introspection)
>>         ("libtool" ,libtool)
>>         ("intltool" ,intltool)))
>> +    (propagated-inputs
>> +     ;; colord.pc refers to all these.
>> +     `(("glib" ,glib)
>> +       ("libudev" ,eudev)
>
> I suppose it doesn't matter, but normally for 'eudev' we make the key
> string "udev".  Or did you mean to use 'libgudev' here?
colord use both GObject and C-based udev API, unless we disable gudev
in eudev, it will still use GUDEV from eudev, so I don't touch it now,
I agree use 'udev' is less confusing.
>
>> +       ("lcms" ,lcms)))
>>      (inputs
>> -     `(("eudev" ,eudev)
>> -       ("dbus-glib" ,dbus-glib)
>> +     `(("dbus-glib" ,dbus-glib)
>>         ("libusb" ,libusb)
>> -       ("lcms" ,lcms)
>>         ("sqlite" ,sqlite)
>>         ("polkit" ,polkit)
>>         ("sane-backends" ,sane-backends)))
Pushed, thanks for review!