Re: [PATCH] python2-ansible, python-ccm and dependencies

[Eric Dvorsak]

Thank you Ricardo and Alex for taking the time to review and comment my patch. I edited it to take your advices into account. I hope I did not miss anything this time

Eric

2015-07-25 12:07 GMT+02:00 Ricardo Wurmus <address@hidden>:

Hi Eric,

> I added the following package definitions to python.scm :
>
> - python2-ansible
> - python-passlib
> - python-py-bcrypt
> - python-paramiko
> - python-httplib2
> - python-ecdsa
> - python-ccm

we normally make separate commits for separate packages.  The only
exception is for when we add python-<name> as well as python2-<name>;
they usually go together in the same commit.

Please also run ‘guix lint package-name’ for each of the new packages.
It will tell you a couple of things that you could do to improve.

One thing I noticed is that the description you provide for the packages
is the same as the synopsis.  The description, however, should provide
more information and it should be complete sentences (with
punctuation).

Things like ‘("python-setuptools" ,python-setuptools)’ are to be placed
in the list of ‘native-inputs’.  ‘native-inputs’ are only used at build
time.

Finally, there is no space between your definition of ‘python2-ccm’ and
the existing definition of ‘python-pytz’.

The other patch looks good to me, but it appears that this is a patch by
Mark Weaver.  Did you submit it by accident?

~~ Ricardo

0001-gnu-Add-python2-pycrypto.patch
Description: Text Data

0002-gnu-Add-python-ccm.patch
Description: Text Data

0003-gnu-Add-python-ecdsa.patch
Description: Text Data

0004-gnu-Add-python-httplib2.patch
Description: Text Data

0005-gnu-Add-python-paramiko.patch
Description: Text Data

0006-gnu-Add-python-py-bcrypt.patch
Description: Text Data

0007-gnu-Add-python-passlib.patch
Description: Text Data

0008-gnu-Add-python2-ansible.patch
Description: Text Data