[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] gnu: Add oslotest.
From: |
Thompson, David |
Subject: |
Re: [PATCH 02/11] gnu: Add oslotest. |
Date: |
Wed, 22 Jul 2015 22:06:44 -0400 |
On Wed, Jul 22, 2015 at 6:13 PM, Cyril Roelandt <address@hidden> wrote:
> On 07/20/2015 06:14 PM, Thompson, David wrote:
>> On Wed, Jul 15, 2015 at 7:32 PM, Cyril Roelandt <address@hidden> wrote:
>>> * gnu/packages/openstack.scm: New file.
>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it here.
>>> * gnu/packages/python.scm (python-appdirs, python2-appdirs): New variables.
>>
>> Could you break this patch so that there is one package per patch?
>
> Hum, I'm not sure whether that really makes sense. The main "feature" I
> want to add is the package for oslotest, so it seemed natural to add its
> dependencies in the same patch, especially since there is only one.
The commit log doesn't show this, though. According to your log, 2
new variables were added, but it turns out there were more upon closer
inspection.
We view each additional package as a logical change that should be in
its own commit. And just to prevent any further confusion, the
'python2' variant of a package can be included in the patch for the
python3 version.
> Plus, this would make this patch series *huge*. Do we really want that?
I'd rather not hide that fact by stuffing more packages into a patch
than there ought to be.
>> Also, all of the Python packages in openstack.scm look like they
>> really belong in python.scm. Could you move them?
>>
>
> Well, in the end, we could have everything from PyPI in python.scm.
> OpenStack is a huge project, so I thought it would make sense to have
> its packages in their own file. WDYT?
If they are solely for OpenStack then that's fine.
Thanks,
- Dave
- [PATCH 00/11] Add a few modules from the Oslo library., Cyril Roelandt, 2015/07/15
- [PATCH 01/11] gnu: Bump python-six to 1.9.0., Cyril Roelandt, 2015/07/15
- [PATCH 03/11] gnu: Add oslo.i18n., Cyril Roelandt, 2015/07/15
- [PATCH 02/11] gnu: Add oslotest., Cyril Roelandt, 2015/07/15
- Re: [PATCH 02/11] gnu: Add oslotest., Mathieu Lirzin, 2015/07/16
- Re: [PATCH 02/11] gnu: Add oslotest., Thompson, David, 2015/07/20
- Re: [PATCH 02/11] gnu: Add oslotest., Cyril Roelandt, 2015/07/22
- Re: [PATCH 02/11] gnu: Add oslotest., Ian Denhardt, 2015/07/22
- Re: [PATCH 02/11] gnu: Add oslotest.,
Thompson, David <=
- Re: [PATCH 02/11] gnu: Add oslotest., Ludovic Courtès, 2015/07/23
- Re: [PATCH 02/11] gnu: Add oslotest., Cyril Roelandt, 2015/07/23
- Re: [PATCH 02/11] gnu: Add oslotest., Thompson, David, 2015/07/23
[PATCH 04/11] gnu: Add oslo.config, Cyril Roelandt, 2015/07/15
[PATCH 05/11] gnu: Add oslo.utils., Cyril Roelandt, 2015/07/15
[PATCH 06/11] gnu: Add oslo.context., Cyril Roelandt, 2015/07/15
[PATCH 07/11] gnu: Add oslo.serialization., Cyril Roelandt, 2015/07/15
[PATCH 08/11] gnu: Add oslo.log., Cyril Roelandt, 2015/07/15
[PATCH 09/11] gnu: Add oslo.cache., Cyril Roelandt, 2015/07/15