|
From: | Ben Woodcroft |
Subject: | Re: [PATCH] Add seqtk. |
Date: | Sat, 18 Jul 2015 17:51:01 +1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 24/06/15 22:09, Mark H Weaver wrote:
However, there's a bigger problem here. Some of the code is not clearly licensed or has invalid copyright notices: * The copyright notice on kstring.h lacks copyright dates. * The copyright dates in seqtk.c and LICENSE are incorrect ("20082-2012"). * ksw.h and trimadap.c lack any copyright notice at all. The mere presence of a LICENSE file is not enough, especially given the lack of any statement about the code license in the README. Would you be willing to ask the author to fix these issues?
I did this almost a month ago https://github.com/lh3/seqtk/pull/60But no response as yet. I think the common sense here is that it is expat licensed, WDYT? It would be a shame to exclude this software as it is quite well used in bioinformatics generally, but I'm happy to defer to your decision.
[Prev in Thread] | Current Thread | [Next in Thread] |