Re: [PATCH] gnu: Add gst-plugins-ugly

[Mark H Weaver]

Mark H Weaver <address@hidden> writes:

> David Hashe <address@hidden> writes:
>
>> Thanks for clarifying. Besides patents, my other concern was
>> licensing. Specifically, the page I linked about gst-plugins-ugly
>> includes the following:
>>
>> The license on either the plug-ins or the supporting libraries might
>> not be how we'd like.
>
> Yes, we'll need to investigate this.
>
>> Rather vague, but a bit worrying. However, you're right that Debian
>> includes it, as do Trisquel and Parabola (both free distributions), so
>> I agree that this is probably something we can include.
>
> I looked in Parabola's blacklist
> <https://projects.parabola.nu/blacklist.git/tree/> and didn't find
> issues listed with gst-plugins-ugly, so I guess that's a good sign.
>
> I've attached a preliminary 'gst-plugins-ugly' package for Guix.  Note
> that this depends on commit 23da88f61e82e2b32d6dedb3af467f665cd03bf5
> "gnu: liba52: Build shared library", which I pushed to master just a few
> minutes ago.

I've since added libmpeg2 (commit e088410984) and noticed that we
already have libdvdread and libdvdnav (which I just updated).

Here's an updated version of my preliminary 'gst-plugins-ugly' patch.

     Mark


>From 60e3d1398cf058b10947727dcb8c97b11332c8e3 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <address@hidden>
Date: Tue, 7 Jul 2015 02:36:18 -0400
Subject: [PATCH] gnu: Add gst-plugins-ugly.

* gnu/packages/gstreamer.scm (gst-plugins-ugly): New variable.
---
 gnu/packages/gstreamer.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 0f3a0fb..7ab96d2 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -243,6 +243,46 @@ GStreamer multimedia library.  This set contains those 
plug-ins which the
 developers consider to have good quality code and correct functionality.")
     (license lgpl2.0+)))
 
+(define-public gst-plugins-ugly
+  (package
+    (name "gst-plugins-ugly")
+    (version "1.4.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://gstreamer.freedesktop.org/src/";
+                           name "/" name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "0rwhljn3f8mp2pfchzfcx4pvps1546dndw9mr56lz50qyqffimaw"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("gst-plugins-base" ,gst-plugins-base)
+       ("liba52" ,liba52)
+       ("libmad" ,libmad)
+       ("lame" ,lame)
+       ("libcdio" ,libcdio)
+       ("twolame" ,twolame)
+       ("libmpeg2" ,libmpeg2)
+       ("libdvdread" ,libdvdread)
+       ;; TODO:
+       ;; * opencore-amr (for the AMR-NB decoder and encoder and the
+       ;;   AMR-WB decoder) <http://sourceforge.net/projects/opencore-amr/>
+       ;; * x264 (for the x264enc H.264 encoder)
+       ;;   <http://www.videolan.org/developers/x264.html>
+       ("orc" ,orc)))
+    (native-inputs
+     `(("glib:bin" ,glib "bin")
+       ("pkg-config" ,pkg-config)
+       ("python-wrapper" ,python-wrapper)))
+    (home-page "http://gstreamer.freedesktop.org/";)
+    (synopsis
+     "GStreamer plugins from the \"ugly\" set.")
+    (description "GStreamer Ugly Plug-ins.  This set contains those plug-ins
+which the developers consider to have good quality code but that might pose
+distribution problems in some jurisdictions, e.g. due to patent threats.")
+    (license lgpl2.0+)))
+
 (define-public gst-libav
   (package
     (name "gst-libav")
-- 
2.4.3