[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ruby-rake-compiler
From: |
Thompson, David |
Subject: |
Re: [PATCH] ruby-rake-compiler |
Date: |
Sat, 4 Jul 2015 10:45:54 -0400 |
On Sat, Jul 4, 2015 at 10:28 AM, Pjotr Prins <address@hidden> wrote:
> On Sat, Jul 04, 2015 at 09:55:57AM -0400, Thompson, David wrote:
>> * Removed the rspec native input. It can be added back in when we can
>> actually run the test suite.
>
> Without rspec it won't build. Alternatively remove tasks/rspec.rake
I was able to build it successfully without it. Is this a runtime
error? I tried this as a quick smoke test and there were no errors:
guix environment --ad-hoc ruby ruby-rake-compiler
--exec="rake-compiler --help"
Am I missing something? Send me a patch if you find an issue.
>> * Fixed license. It's actually the Expat license, which is verrrrry
>> similar to the X11 license.
>
> OK. Not too clear on the difference...
There's an extra clause in the X11 license that is not in the Expat
license. Wikipedia has a blurb about it:
https://en.wikipedia.org/wiki/MIT_License#Various_versions
>> > David: there are quite a few modules now that build gems through 'rake
>> > gem'. Would it be an idea to try that by default when there is no
>> > gemspec file?
>>
>> Yes, I think that would be a good change. Want to write a patch that
>> does that and updates all of the relevant package recipes?
>
> I'll give it a shot soon.
Cool. Should be an easy patch to the build phase. :)
- Dave