[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add setBfree.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH] Add setBfree. |
|
Date: |
Tue, 23 Jun 2015 14:53:22 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> From 00bd892e00e2f8d1261f4fffaf2a9ba31d5961e8 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Thu, 18 Jun 2015 17:36:12 +0200
> Subject: [PATCH 1/2] gnu: ftgl: Propagate "freetype".
>
> * gnu/packages/gl.scm (ftgl)[inputs,propagated-inputs]: Move "freetype" from
> "inputs" to "propagated-inputs".
[...]
> + (propagated-inputs `(("freetype" ,freetype)))
Please explain the reason (Requires.private) in a comment above.
OK with this change.
> From 0110a38d7c1fcf47ffc5691f97966addd379f50c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Thu, 18 Jun 2015 17:37:47 +0200
> Subject: [PATCH 2/2] gnu: Add setBfree.
>
> * gnu/packages/audio.scm (setbfree): New variable.
LGTM!
Perhaps it would be more appropriate to have it in music.scm, no?
Thanks,
Ludo’.