Re: [PATCH 02/10] gnu: base: Fix a bug that occurs in non-Linux systems.

[Ludovic Courtès]

Manolis Ragkousis <address@hidden> skribis:

> Ok to push this patch to wip-hurd? As this is something that doesn't
> affect Linux,
> there is no need to push it to core-updates.

I think the policy should be to push anything that is not Hurd-specific
to core-updates (or master, whichever is appropriate.)

This patch happens to fix something on GNU/Hurd, but it has no effect on
GNU/Linux, so I would suggest pushing it to core-updates.

WDYT?

> From 6de900b0cf21af361c3b5910b339ecab8ded5e4b Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Thu, 21 May 2015 16:47:26 +0300
> Subject: [PATCH 1/5] gnu: base: Fix a bug that occurs in non-Linux systems.
>
> * gnu/packages/base.scm (tar): Apply patch.
> * gnu/packages/patches/tar-d_ino_in_dirent-fix.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +++ b/gnu/packages/patches/tar-d_ino_in_dirent-fix.patch
> @@ -0,0 +1,46 @@
> +commit e9ddc08da0982f36581ae5a8c7763453ff41cfe8
> +Author: Sergey Poznyakoff <address@hidden>
> +Date:   Thu Sep 25 00:22:16 2014 +0300
> +
> +    Bugfixes.
> +    
> +    * doc/tar.1: Fix typo in font spec.
> +    * src/tar.c (sort_mode_arg, sort_mode_flag): Protect "inode"
> +    (SAVEDIR_SORT_INODE) with D_INO_IN_DIRENT
> +
> +diff --git a/doc/tar.1 b/doc/tar.1
> +index 9000627..b91de63 100644
> +--- a/doc/tar.1
> ++++ b/doc/tar.1
> +@@ -879,7 +879,7 @@ Exclude files matching patterns listed in FILE.
> + \fB\-\-strip\-components\fR=\fINUMBER\fR
> + Strip \fINUMBER\fR leading components from file names on extraction.
> + .TP
> +-\fB\-\-transform\fR=\fIEXPRESSION\dR, \fB\-\-xform\fR=\fIEXPRESSION\fR
> ++\fB\-\-transform\fR=\fIEXPRESSION\fR, \fB\-\-xform\fR=\fIEXPRESSION\fR
> + Use sed replace \fIEXPRESSION\fR to transform file names.
> + .SS File name matching options
> + These options affect both exclude and include patterns.
> +diff --git a/src/tar.c b/src/tar.c
> +index 225c624..f8102e0 100644

Could you just remove the doc/tar.1 part of the patch since it’s
unrelated and unneeded?

OK to push to core-updates with this change.

Thank you!

Ludo’.