Re: [PATCH] gnu: octave: Add fftw, arpack, and glu inputs.

[Mark H Weaver]

Eric Bavier <address@hidden> writes:

> This patch adds a few more inputs to our octave package.  Arpack is
> needed for the "eigs" function.  Previously, we had the fltk input,
> but without glu it's essentially useless.
>
> I had wanted to also add Suitesparse, but there are some compilation
> problems yet.
>
> I took the liberty of wrapping some lines to 80 columns at the same
> time.

Okay.

> From d412eca63adfded2aae5d19777d0928784a2b58f Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Fri, 8 May 2015 14:44:29 -0500
> Subject: [PATCH] gnu: octave: Add fftw, arpack, and glu inputs.
>
> * gnu/packages/maths.scm (octave)[inputs]: Add fftw, fftwf, arpack,
>   and glu.
>   [description]: Wrap to 80 columns.

[...]

> @@ -411,11 +416,11 @@ extremely large and complex data collections.")
>                           "/bin/sh"))))
>      (home-page "http://www.gnu.org/software/octave/";)
>      (synopsis "High-level language for numerical computation")
> -    (description "GNU Octave is a high-level interpreted language that is 
> specialized
> -for numerical computations.  It can be used for both linear and non-linear
> -applications and it provides great support for visualizing results.  Work may
> -be performed both at the interactive command-line as well as via script
> -files.")
> +    (description "GNU Octave is a high-level interpreted language that is
> +specialized for numerical computations.  It can be used for both linear and
> +non-linear applications and it provides great support for visualizing 
> results.
> +Work may be performed both at the interactive command-line as well as via
> +script files.")

As you have it now, the first line of the string will actually be much
shorter than the others.

Instead, please put the open quote on the next line, below the 'd' in
"description", and then reformat.  I think you'll find that it breaks
the lines as they were before, but the source code will then fit within
80 columns.

Otherwise, it looks good to me.  Okay to push with this change.

     Thanks!
       Mark