[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] guix: build: Add transitive source building.
From: |
Eric Bavier |
Subject: |
Re: [PATCH 2/2] guix: build: Add transitive source building. |
Date: |
Fri, 24 Apr 2015 08:19:20 -0500 |
Revisiting this (old) thread...
>Eric Bavier <address@hidden> skribis:
>
>> * guix/scripts/build.scm (%options): Add --sources option.
>> (package-sources, package-direct-sources)
>> (package-transitive-sources, package-source-derivations): New
>> procedures.
>> (options->derivations)[--sources]: Use them.
>> * doc/guix.texi (Invoking guix build): Document --sources option.
>> * tests/guix-build.sh: Add tests.
>
>[...]
>
>> @item --sources
>> +An extension of the @code{--source} option. If a package's source is
>
>What about starting with a couple of sentences that better describe what
>it does and what the use case is, like:
>
> Fetch and return the source of @var{package-or-derivation} and all
> their dependencies, recursively. This is a handy way to obtain a
> local copy of all the source code needed to build @var{packages},
> allowing you to eventually build them even without network
> access.
I liked your wording, so I used it ;)
>BTW, what happens when one passes arguments that are not packages?
>Like:
>
> guix build --sources /gnu/store/...-foo.drv
It behaves in the way 'guix build -S' currently behaves with a
derivation, it just builds the derivation. It might be interesting if
it examined the derivation and built any sources associated with it, but
that can be a later patch.
>> + --sources[=TYPE] build source derivations; TYPE may
>> optionally be one
>> + of \"package\", \"all\" (default), or
>> \"transitive\"."))
>
>No period.
Good catch, thanks.
>> +(define (package-sources package)
>
>This procedure appears to be unused (and is awkward anyway ;-)).
Removed.
>> +(define (package-direct-sources package)
>> + "Return all source origins associated with PACKAGE; including
>> origins in
>> +PACKAGE's inputs."
>> + `(,@(or (and=> (package-source package) list) '())
>> + ,@(filter-map (match-lambda
>> + ((_ (? origin? orig) _ ...)
>> + orig)
>> + (_ #f))
>> + (package-direct-inputs package))))
>> +
>> +(define (package-transitive-sources package)
>> + "Return PACKAGE's direct sources, and its input sources,
>> recursively."
>> + (delete-duplicates
>> + (concatenate (filter-map (match-lambda
>> + ((_ (? origin? orig) _ ...)
>> + (list orig))
>> + ((_ (? package? p) _ ...)
>> + (package-direct-sources p))
>> + (_ #f))
>> + (bag-transitive-inputs
>> + (package->bag package))))))
>
>Perhaps these two could go to (guix packages), with a test in
>tests/packages.scm.
Done in patch [1/2].
>> +# foo.tar.gz
>> +guix build -d -S foo
>> +guix build -d -S foo | grep -e 'foo\.tar\.gz'
>
>Nice tests, thanks for taking the time!
No problem. I kinda like writing tests. :)
Eric Bavier (2):
guix: packages: Add package-direct-sources and
package-transitive-sources.
guix: build: Add transitive source building.
doc/guix.texi | 43 +++++++++++++++++++++++++
guix/packages.scm | 24 ++++++++++++++
guix/scripts/build.scm | 55 +++++++++++++++++++++----------
guix/tests.scm | 10 +++++-
tests/guix-build.sh | 82 ++++++++++++++++++++++++++++++++++++++++++++++++
tests/packages.scm | 30 +++++++++++++++++
6 files changed, 226 insertions(+), 18 deletions(-)
--
1.7.9.5
- Re: [PATCH 2/2] guix: build: Add transitive source building.,
Eric Bavier <=