[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] profiles: Generate GHC's package database cache.
From: |
Federico Beffa |
Subject: |
Re: [PATCH] profiles: Generate GHC's package database cache. |
Date: |
Sun, 5 Apr 2015 22:33:27 +0200 |
On Sun, Apr 5, 2015 at 10:24 PM, Mark H Weaver <address@hidden> wrote:
>>
>> ;; Don't depend on GHC when there's nothing to do.
>> (if (any (cut string-prefix? "ghc" <>)
>> (map manifest-entry-name (manifest-entries manifest)))
>> (gexp->derivation "ghc-package-cache" build
>> #:modules '((guix build utils))
>> #:local-build? #t)
>> (gexp->derivation "ghc-package-cache" #~(mkdir #$output))))
>
> Sure, this would be fine, although I wonder if we could replace the
> 'string-prefix?' with 'string=?'. If so, the conditional could be
I used 'string-prefix?' to catch any GHC library (that we are
prefixing with 'ghc-...'). However, to compile such a library we need
GHC, so I think that 'string=?' should do.
> changed to:
>
> (if (member "ghc" (map manifest-entry-name (manifest-entries manifest)))
> ...)
>
> What do you think?
Thanks, I will update the patch.
Regards,
Fede
- [PATCH] profiles: Generate GHC's package database cache., Federico Beffa, 2015/04/04
- Re: [PATCH] profiles: Generate GHC's package database cache., Mark H Weaver, 2015/04/05
- Re: [PATCH] profiles: Generate GHC's package database cache., Federico Beffa, 2015/04/05
- Re: [PATCH] profiles: Generate GHC's package database cache., Mark H Weaver, 2015/04/05
- Re: [PATCH] profiles: Generate GHC's package database cache.,
Federico Beffa <=
- Re: [PATCH] profiles: Generate GHC's package database cache., Federico Beffa, 2015/04/06
- Re: [PATCH] profiles: Generate GHC's package database cache., Mark H Weaver, 2015/04/06
- Re: [PATCH] profiles: Generate GHC's package database cache., Federico Beffa, 2015/04/06
- Re: [PATCH] profiles: Generate GHC's package database cache., Ludovic Courtès, 2015/04/06
- Re: [PATCH] profiles: Generate GHC's package database cache., Alexandre Héaumé, 2015/04/10
Re: [PATCH] profiles: Generate GHC's package database cache., Ludovic Courtès, 2015/04/05