Re: [PATCHES] gnu: Add livestreamer.

[Mark H Weaver]

David Thompson <address@hidden> writes:

> This small patch set adds livestreamer, which is like youtube-dl but for
> live streaming websites, and its missing dependencies.

Excellent!  See below for comments.

> From 67f1a7d362f9d379b4fa5f905b01193b5531509d Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Sat, 4 Apr 2015 13:15:40 -0400
> Subject: [PATCH 1/3] gnu: python-requests: Fix Python 2 version and add
>  support for Python 3.

Looks good!

> From 472370aabae4171e69eccf8927aa09337b49cfcf Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Sat, 4 Apr 2015 13:17:35 -0400
> Subject: [PATCH 2/3] gnu: Add python-singledispatch.
>
> * gnu/packages/python.scm (python-singledispath, python2-singledispatch): New

Typo: "python-singledispath" is missing the "c".

>   variables.
> ---
>  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8c86d5a..8f19f89 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3448,3 +3448,33 @@ Python style, together with a fast and comfortable 
> execution environment.")
>  library for Python programs.  It is useful to implement low-level X clients.
>  It is written entirely in Python.")
>      (license gpl2+)))
> +
> +(define-public python-singledispatch
> +  (package
> +    (name "python-singledispatch")
> +    (version "3.4.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             
> "https://pypi.python.org/packages/source/s/singledispatch/singledispatch-";
> +             version
> +             ".tar.gz"))

To avoid the long lines, how about this?

--8<---------------cut here---------------start------------->8---
       (uri (string-append
             "https://pypi.python.org/packages/source/s/singledispatch/";
             "singledispatch-" version ".tar.gz"))
--8<---------------cut here---------------end--------------->8---

> From af76cababb6550081be6aaf9db45ef370b278df1 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Sat, 4 Apr 2015 13:18:40 -0400
> Subject: [PATCH 3/3] gnu: Add livestreamer.
>
> * gnu/packages/video.scm (livestreamer): New variable.
> ---
>  gnu/packages/video.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index c6eb859..98f4a3a 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1261,3 +1261,29 @@ codec library.  It uses ASP features such as b-frames, 
> global and quarter
>  pixel motion compensation, lumi masking, trellis quantization, and H.263, 
> MPEG
>  and custom quantization matrices.")
>      (license license:gpl2+)))
> +
> +(define-public livestreamer
> +  (package
> +    (name "livestreamer")
> +    (version "1.12.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/chrippa/livestreamer/archive/v";
> +                    version ".tar.gz"))

Please add a 'file-name' field to this 'origin'.  Otherwise the store
name of the source code will be /gnu/store/...-v1.21.1.tar.gz.

Otherwise looks good to me!

    Thanks,
      Mark