guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add aalib.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add aalib.
Date: Sat, 04 Apr 2015 23:06:56 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

宋文武 <address@hidden> skribis:

> * gnu/packages/video.scm (aalib): New variable.

[...]

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool"  ,libtool)
> +       ("makeinfo" ,texinfo)))

[...]

> +         ;; Regenerate the configure script to accept assignments of SHELL
> +         ;; and CONFIG_SHELL.
> +         (add-after unpack bootstrap
> +                    (lambda _
> +                      (zero? (system* "autoreconf" "-vfi")))))))

Please don’t do that because it adds big dependencies to the package.
Instead, could you change it to follow the same approach as in time.scm?

Other than that it LGTM.

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]