[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] import: pypi: Detect inputs.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH] import: pypi: Detect inputs. |
|
Date: |
Thu, 26 Mar 2015 14:15:36 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Cyril Roelandt <address@hidden> skribis:
> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.
Just some superficial comments. David, anything else?
> +(define (guix-hash-url filename)
> + "Return the hash of FILENAME in nix-base32 format."
> + (bytevector->nix-base32-string
> + (call-with-input-file filename port-sha256)))
Please remove and use:
(bytevector->nix-base32-string (file-sha256 file))
> +(define (guix-name name)
‘python->package-name’? + docstring
Could you augment tests/pypi.scm with a test where dependencies are
parsed?
Thanks!
Ludo’.