Re: [PATCHES] Add recode, enca.

[Taylan Ulrich Bayırlı/Kammer]

address@hidden (Ludovic Courtès) writes:

>> I'm not sure if the need to specify the ".libs" subdirectory is
>> Guix-specific or not.
>
> I don’t think so (the package uses libtool, right?)  This may be a
> genuine upstream bug, which could go unnoticed when the user happens to
> have a librecode.so in the loader’s search path.

OK, I left the patching in the build phase for now but filed a bug on
GitHub.

>> +    (license (list license:gpl2+ license:lgpl2.1+))))
>
> Please add a comment telling if this is an ‘or’ or an ‘and’.

The reason I had listed both was that some Copyright file from Debian
claims the program is under GPL and the library under LGPL, but looking
through the sources I could see no sensible separation of program and
library source files after all, and no explicit mention of what license
applies to what other than individual GPL or LGPL headers on seemingly
arbitrary .c files, so I set the license to just gpl2+ after all.

Thanks for the review!  Will push along with all the other patches. :-)

Taylan