guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add quvi.


From: Andreas Enge
Subject: Re: [PATCH] gnu: Add quvi.
Date: Sat, 7 Mar 2015 00:05:39 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Mar 06, 2015 at 05:47:26PM -0500, Mark H Weaver wrote:
> I'm familiar with these packages, and I tend to agree that they are so
> closely tied that it's reasonable to commit them together.

That is not common practice so far, no? I do not see what would be
the problem when committing them separately.

> > Your indentation (here and further down) is not quite consistens, sometimes
> > it it one, sometimes two spaces.
> He's using the auto-indenter of Emacs Scheme Mode, which faithfully
> follows the rules in our .dir-locals.el file.

Curious. Why does it use sometimes one, sometimes two spaces? Can this be
explained so that non-emacs users follow the same style?

> >> +          (string-append "liblua_LIBS=-L" lua "/libs -llua")))))
> > These are two flags and should be two entries in the list.
> What Taylan wrote above looks right to me.  The -L[...] and -llua are
> two flags, but the variable setting "liblua_LIBS=-L[...]/libs -llua"
> needs to be one argument to configure.

I do not get this. Why should two flags be one argument? Do you mean that
on the command line, one would write:
  ./configure "liblua_LIBS=-L/gnu/store/.../libs -llua"
and that the call of system* adds these quotation marks implicitly?

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]