guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add urwid


From: Mark H Weaver
Subject: Re: [PATCH] gnu: Add urwid
Date: Mon, 02 Feb 2015 00:42:41 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Omar Radwan <address@hidden> writes:
> Here's a patch that does all the changes you requested to the previous
> patch file

A few problems here:

(1) This new version doesn't even compile, because of several typos.
    Please always test before sending patches.

(2) Instead of sending a patch that assumes the first version of your
    patch has been applied, please send a patch that can be applied by
    itself.

(3) In the description, don't put two spaces between every two words,
    just between sentences.

(4) In the source URI specification, please follow our Scheme
    indentation and spacing conventions, as I showed in my last message
    in this thread.

Can you send an updated patch?

      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]